Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contacts: remove unnecessary future check since we guard in fact intake #292

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Oct 24, 2024

OTT, this is causing crashes for anyone trying to subscribe to someone who's breached or nuked contacts but hasn't updated their profile since.

@arthyn arthyn requested review from Fang- and mikolajpp October 24, 2024 21:31
desk/app/contacts.hoon Outdated Show resolved Hide resolved
desk/app/contacts.hoon Outdated Show resolved Hide resolved
ofile if sub is older
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out. Thanks!

@arthyn arthyn merged commit f2d8064 into develop Oct 24, 2024
1 check passed
@arthyn arthyn deleted the hm/fix-contacts-breach-handling branch October 24, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants